prelude-correlator: spamhaus drop plugin
this is a replica of the dshield plugin, but for the spamhaus drop list. it does require the use of some other python packages for CIDR lookup; so keep that in mind when merging (see attached patch).
double check the installation settings; this was my first attempt at that too.
#1 Updated by Yoann VANDOORSELAERE about 14 years ago
Hi Wes, thanks for the patch!
Here is a quick review:
- The NetCIDR modules have been deprecated in favor of the more widely available netaddr module, check http://oubiwann.blogspot.com/2008/08/netaddr-python-library.html
- The __ipNormalize() function could be removed since it is now unused.
- Could you please add the Dshield plugin copyright, adding your contact to the author lists ?
This is a nice addition, thanks for the contribution!
Might you post an updated patch?
#2 Updated by Anonymous about 14 years ago
re-formulated. They don't have all the features in netaddr that NetCIDR had (at least that's what they said in the doc), but given that it's all but deprecated I just added a few lines using the new netaddr packages and tested it. Appears to work OK.
all the other stuff added as requested.
#3 Updated by Yoann VANDOORSELAERE about 14 years ago
- File 0001-added-spamhausdrop.py-to-plugins.patch added
Thanks for the update!
Attached is a modified version of your patch, that provides compatibility with earlier netaddr module version, use IPSet() in order to match addresses, and download the initial database on source distribution generation.
Could you please let me know if this modified patch doesn't break anything on your side?